linux-kernel - Re: [PATCH 2/2] platform/x86: export thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d423ac66-bb8f-44e4-b995-f88cf2ece70c@app.fastmail.com>
Date: Thu, 08 May 2025 11:01:50 -0400
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Cc: "Hans de Goede" <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 ikepanhc@...il.com, "Armin Wolf" <W_Armin@....de>,
 linux-kernel@...r.kernel.org,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] platform/x86: export thinkpad_acpi handles

On Thu, May 8, 2025, at 10:31 AM, Andy Shevchenko wrote:
> On Wed, May 07, 2025 at 03:04:35PM -0400, Mark Pearson wrote:
>> Add API to be able to get the thinkpad_acpi various handles.
>> 
>> Will use this to start pulling some of the thinkpad_acpi functionality
>> into separate modules in the future.
>
> ...
>
>> +#ifndef _TP_ACPI_H_
>> +#define _TP_ACPI_H_
>
> + include for  acpi_handle typedef.
> Or it the forward declaration works
>
> acpi_handle;
>
> but I haven't checked and my gut feelings that it's not correct syntax as
> compiler doesn't know what the heck this word means.
>

OK - I'll have a look and figure out what makes sense.
Thanks for the review
Mark