linux-kernel - Re: [PATCH 1/4] dt-bindings: i2c: Specify reset as optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250508-atrocious-till-30aad5010c3e@spud>
Date: Thu, 8 May 2025 16:09:56 +0100
From: Conor Dooley <conor@...nel.org>
To: Akhil R <akhilrajeev@...dia.com>
Cc: andi.shyti@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, thierry.reding@...il.com, jonathanh@...dia.com,
	ldewangan@...dia.com, digetx@...il.com, p.zabel@...gutronix.de,
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: i2c: Specify reset as optional

On Tue, May 06, 2025 at 03:29:33PM +0530, Akhil R wrote:
> Specify reset as optional in the description for controllers that has an
> internal software reset available

Optionality of properties is not determined by text. The property is not
marked required in the binding, and therefore is optionally on all
platforms. If some platforms require it, you should submit a patch making
it mandatory there (via the required keyword).

Cheers,
Conor.

> 
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> index b57ae6963e62..19aefc022c8b 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> @@ -97,7 +97,9 @@ properties:
>  
>    resets:
>      items:
> -      - description: module reset
> +      - description: |
> +          Module reset. This property is optional for controllers in Tegra194 and later
> +          chips where an internal software reset is available as an alternative.
>  
>    reset-names:
>      items:
> -- 
> 2.43.2
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)