linux-kernel - Re: [PATCH v2 0/5] iio: magnetometer: Add QMC5883L driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0b305dd-8eb5-412c-b9c8-d2b274707f66@baylibre.com>
Date: Thu, 8 May 2025 10:26:13 -0500
From: David Lechner <dlechner@...libre.com>
To: Brajesh Patil <brajeshpatil11@...il.com>, jic23@...nel.org,
 lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v2 0/5] iio: magnetometer: Add QMC5883L driver support

On 5/8/25 7:08 AM, Brajesh Patil wrote:
> This series introduces support for the QST QMC5883L 3-axis magnetometer,
> a magnetic sensor with I2C interface.
> 
> The implementation follows standard IIO conventions and includes:
> 
> Patch 1/5: dt-bindings: vendor-prefixes
> - Adds 'qst' prefix for QST Corporation
> 
> Patch 2/5: dt-bindings: iio: magnetometer - Adds QMC5883L bindings
> - Adds compatible string and required properties
> - Includes example device tree node
> 
> Patch 3/5: iio: magnetometer - Base driver implementation
> - Basic register access via regmap
> - X/Y/Z axis and temperature readings
> - Triggered buffer support
> - Initialization and core functionality
> 
> Patch 4/5: Extended sysfs attributes and configuration
> - ODR (10-200Hz) and FSR (±2G/±8G) control
> - Mode selection (standby/continuous)
> - Oversampling ratio configuration (512-64)
> - Status monitoring (DRDY/OVL flags)
> - Available scale and sampling frequency attributes
> 
> Patch 5/5: Advanced features and power management
> - Mount matrix support for orientation compensation
> - Power management (suspend/resume)
> - Control register features (soft reset, pointer rollover)

This sort of information should be in the descriptions of the individual patches,
not in the cover letter.

> 
> The driver has been tested on a Raspberry Pi 5 and all features have been verified.

This info is good to have in the cover letter. Even better though would be to
explain a bit about the actual methodology of how you tested it.

Also, a v2 should have a link to v1 and describe the changes made since then.

It look like v2 was sent the same day as v1. Generally, you should wait a week
(or at least a few days) to give others time to review before sending a new
version. 

> 
> Signed-off-by: Brajesh Patil <brajeshpatil11@...il.com>