linux-kernel - Re: [PATCH v2] drm/vmgfx: Use non-hybrid PCI devres API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABQX2QP1U6nUc++5oZf0KVpfXCEMRwX9u0ykq2YNHuQSKx909Q@mail.gmail.com>
Date: Thu, 8 May 2025 11:39:39 -0400
From: Zack Rusin <zack.rusin@...adcom.com>
To: phasta@...nel.org
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/vmgfx: Use non-hybrid PCI devres API

On Thu, May 8, 2025 at 6:40 AM Philipp Stanner <phasta@...lbox.org> wrote:
>
> On Wed, 2025-04-23 at 14:06 +0200, Philipp Stanner wrote:
> > vmgfx enables its PCI device with pcim_enable_device(). This,
> > implicitly, switches the function pci_request_regions() into managed
> > mode, where it becomes a devres function.
> >
> > The PCI subsystem wants to remove this hybrid nature from its
> > interfaces. To do so, users of the aforementioned combination of
> > functions must be ported to non-hybrid functions.
> >
> > Moreover, since both functions are already managed in this driver,
> > the
> > calls to pci_release_regions() are unnecessary.
> >
> > Remove the calls to pci_release_regions().
> >
> > Replace the call to sometimes-managed pci_request_regions() with one
> > to
> > the always-managed pcim_request_all_regions().
> >
> > Signed-off-by: Philipp Stanner <phasta@...nel.org>
>
> *PING*

Thanks, that looks great. I missed it because the driver's name is
vmwgfx. I'd be happy to fix the subject for you while pushing this to
drm-misc-fixes, if you're ok with it of course. Otherwise:
Reviewed-by: Zack Rusin <zack.rusin@...adcom.com>

z

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5414 bytes)