[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025050811-capricorn-poise-4e80@gregkh>
Date: Thu, 8 May 2025 17:49:32 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Heikki Huttu <heissendo88@...il.com>
Cc: Ian Abbott <abbotti@....co.uk>, hsweeten@...ionengravers.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] comedi: drivers: adl_pci9118.c: Edit file so that
checkpatch.pl has 0 typo errors
On Thu, May 08, 2025 at 06:32:04PM +0300, Heikki Huttu wrote:
> Wed, May 07, 2025 at 10:04:05AM +0100, Ian Abbott kirjoitti:
> > On 06/05/2025 17:07, Heikki Huttu wrote:
> > > Fix errors produced by checkpath.pl about typos.
> > >
> > > Signed-off-by: Heikki Huttu <heissendo88@...il.com>
> > > ---
> > >
> > > V2: Removed all modifications done to parenthesis. Edit Patch name and
> > > only typo fixes remain.
> > >
> > > drivers/comedi/drivers/adl_pci9118.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/comedi/drivers/adl_pci9118.c b/drivers/comedi/drivers/adl_pci9118.c
> > > index a76e2666d583..67c663892e48 100644
> > > --- a/drivers/comedi/drivers/adl_pci9118.c
> > > +++ b/drivers/comedi/drivers/adl_pci9118.c
> > > @@ -32,7 +32,7 @@
> > > * ranges).
> > > *
> > > * There are some hardware limitations:
> > > - * a) You cann't use mixture of unipolar/bipoar ranges or differencial/single
> > > + * a) You can't use mixture of unipolar/bipolar ranges or differential/single
> > > * ended inputs.
> > > * b) DMA transfers must have the length aligned to two samples (32 bit),
> > > * so there is some problems if cmd->chanlist_len is odd. This driver tries
> > > @@ -227,7 +227,7 @@ struct pci9118_private {
> > > struct pci9118_dmabuf dmabuf[2];
> > > int softsshdelay; /*
> > > * >0 use software S&H,
> > > - * numer is requested delay in ns
> > > + * number is requested delay in ns
> > > */
> > > unsigned char softsshsample; /*
> > > * polarity of S&H signal
> >
> > The patch looks fine, thanks.
> >
> > Reviewed-by: Ian Abbott <abbotti@....co.uk>
> >
> > I don't have commit access to any pulled trees, so could you please resend
> > with Greg Kroah-Hartman <gregkh@...uxfoundation.org> in the Cc list? Feel
> > free to add my Reviewed-by: line above when resending. You can leave the
> > patch at version v2 since the patch and description hasn't changed.
> >
> > --
> > -=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company )=-
> > -=( registered in England & Wales. Regd. number: 02862268. )=-
> > -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> > -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
>
> Thank you Ian! When you have the time, could you please take a look at
> this patch Greg? Thank you!
>
> Fix errors produced by checkpath.pl about typos.
>
> Signed-off-by: Heikki Huttu <heissendo88@...il.com>
> Reviewed-by: Ian Abbott <abbotti@....co.uk>
> ---
>
> V2: Removed all modifications done to parenthesis. Edit Patch name and
> only typo fixes remain.
>
> drivers/comedi/drivers/adl_pci9118.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/comedi/drivers/adl_pci9118.c b/drivers/comedi/drivers/adl_pci9118.c
> index a76e2666d583..67c663892e48 100644
> --- a/drivers/comedi/drivers/adl_pci9118.c
> +++ b/drivers/comedi/drivers/adl_pci9118.c
> @@ -32,7 +32,7 @@
> * ranges).
> *
> * There are some hardware limitations:
> - * a) You cann't use mixture of unipolar/bipoar ranges or differencial/single
> + * a) You can't use mixture of unipolar/bipolar ranges or differential/single
> * ended inputs.
> * b) DMA transfers must have the length aligned to two samples (32 bit),
> * so there is some problems if cmd->chanlist_len is odd. This driver tries
> @@ -227,7 +227,7 @@ struct pci9118_private {
> struct pci9118_dmabuf dmabuf[2];
> int softsshdelay; /*
> * >0 use software S&H,
> - * numer is requested delay in ns
> + * number is requested delay in ns
> */
> unsigned char softsshsample; /*
> * polarity of S&H signal
This needs to be submitted in a format I can apply it in :)
thanks,
greg k-h
Powered by blists - more mailing lists