linux-kernel - Re: [PATCH v4 04/31] fs/resctrl: Change how and when events are initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2813723-e6df-4949-abcd-a624ad301c7e@intel.com>
Date: Wed, 7 May 2025 20:31:31 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v4 04/31] fs/resctrl: Change how and when events are
 initialized

Hi Tony,

On 4/28/25 5:33 PM, Tony Luck wrote:
> Existing code assumes that all monitor events are associated with
> the RDT_RESOURCE_L3 resource. Also that all event enumeration is
> complete during early resctrl initialization. Neither of these
> assumptions remain true for new events.
> 
> Each resource must include a list of enabled events that is used
> to add appropriately named files when creating mon_data directories
> and to for the contents of "info/{resource}_MON/mon_features" file.
> 
> Move the building of enabled event lists for each resource from
> resctrl_mon_resource_init() to rdt_get_tree() to delay it until
> mount of the resctrl file system.
> 
> Add a new field to struct mon_evt to record which resource each
> event is associated with so that events are added to the correct
> resource event list.
> 

As mentioned in comments to patch #1 I think the array it introduces
can be used instead of rdt_resource::evt_list, simplifying this significantly.

Reinette