[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54291845-a964-4d6a-948c-6d6b14a705dd@intel.com>
Date: Thu, 8 May 2025 08:56:54 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
<patches@...ts.linux.dev>
Subject: Re: [PATCH v4 21/31] x86/resctrl: Add fourth part of telemetry event
enumeration
Hi Tony,
On 4/28/25 5:33 PM, Tony Luck wrote:
> At run time when a user reads an event file the file system code
> provides the enum resctrl_event_id for the event.
>
> Create a lookup table indexed by event id to provide the telem_entry
> structure and the event index into MMIO space.
https://lore.kernel.org/lkml/7bb97892-16fd-49c5-90f0-223526ebdf4c@intel.com/
>
> Enable the events marked as readable from any CPU.
>
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---
> arch/x86/kernel/cpu/resctrl/intel_aet.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c
> index 37dd493df250..e1cb6bd4788d 100644
> --- a/arch/x86/kernel/cpu/resctrl/intel_aet.c
> +++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c
> @@ -97,6 +97,16 @@ static struct event_group *known_event_groups[] = {
>
> #define NUM_KNOWN_GROUPS ARRAY_SIZE(known_event_groups)
>
> +/**
> + * struct evtinfo - lookup table from resctrl_event_id to useful information
> + * @event_group: Pointer to the telem_entry structure for this event
What is telem_entry structure?
> + * @idx: Counter index within each per-RMID block of counters
> + */
> +static struct evtinfo {
> + struct event_group *event_group;
> + int idx;
> +} evtinfo[QOS_NUM_EVENTS];
> +
Reinette
Powered by blists - more mailing lists