[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202505080911.FB6E102@keescook>
Date: Thu, 8 May 2025 09:11:35 -0700
From: Kees Cook <kees@...nel.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
David Hildenbrand <david@...hat.com>,
"Liam R . Howlett" <Liam.Howlett@...cle.com>,
Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
Suren Baghdasaryan <surenb@...gle.com>,
Michal Hocko <mhocko@...e.com>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, Christian Brauner <christian@...uner.io>
Subject: Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
On Thu, May 08, 2025 at 04:33:33PM +0100, Lorenzo Stoakes wrote:
> +cc Christian
>
> And Murphy's law dictates that I forget to add the pidfd bit. Fix-patch
> included...
>
> Adding pidfd as there's a fair chunk of pidfd code that lives in
> kernel/fork.c. Obviously let me know Christian if you feel this makes
> sense.
>
> Thanks! And apologies for noise...
>
> On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote:
> > Currently kernel/fork.c both contains absolutely key logic relating to a
> > number of kernel subsystems and also has absolutely no assignment in
> > MAINTAINERS.
> >
> > Correct this by placing this file in relevant sections - mm core, exec,
> > scheduler and pidfd so people know who to contact when making changes here.
> >
> > scripts/get_maintainers.pl can perfectly well handle a file being in
> > multiple sections, so this functions correctly.
> >
> > Intent is that we keep putting changes to kernel/fork.c through Andrew's
> > tree.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > ---
> > MAINTAINERS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ccc45b0ba843..55332d5bc499 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> > F: include/uapi/linux/auxvec.h
> > F: include/uapi/linux/binfmts.h
> > F: include/uapi/linux/elf.h
> > +F: kernel/fork.c
> > F: mm/vma_exec.c
> > F: tools/testing/selftests/exec/
> > N: asm/elf.h
> > @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> > F: include/linux/mm_*.h
> > F: include/linux/mmdebug.h
> > F: include/linux/pagewalk.h
> > +F: kernel/fork.c
> > F: mm/Kconfig
> > F: mm/debug.c
> > F: mm/init-mm.c
> > @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> > F: include/linux/sched.h
> > F: include/linux/wait.h
> > F: include/uapi/linux/sched.h
> > +F: kernel/fork.c
> > F: kernel/sched/
> >
> > SCHEDULER - SCHED_EXT
> > --
> > 2.49.0
> >
>
> ----8<----
> From 6ab14cfd38a34fc097207dd6b898004a87b9cfa2 Mon Sep 17 00:00:00 2001
> From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Date: Thu, 8 May 2025 16:30:58 +0100
> Subject: [PATCH] add missing pidfd entry
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Yes, please. :) Thanks!
Reviewed-by: Kees Cook <kees@...nel.org>
--
Kees Cook
Powered by blists - more mailing lists