linux-kernel - Re: [PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e13d03e4-623b-43c6-b829-21b6cb8e3bf9@quicinc.com>
Date: Thu, 8 May 2025 22:14:46 +0530
From: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <cros-qcom-dts-watchers@...omium.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@....qualcomm.com>, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card



On 4/29/2025 4:28 PM, Konrad Dybcio wrote:
> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>>
>> Add the sound card node with tested playback over WSA8835 speakers
>> and digital on-board mics.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 49 ++++++++++++++++++++
>>   1 file changed, 49 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 43cbdbe43afd..9cfe648e29bb 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -1078,6 +1078,55 @@
>>   	status = "okay";
>>   };
>>   
>> +&sound {
>> +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
>> +	model = "qcs6490-rb3gen2-snd-card";
>> +
>> +	audio-routing =
>> +		"SpkrLeft IN", "WSA_SPK1 OUT",
> 
> Please unbreak the line and align the entries
> 
> [...]
Ack>
>> +		"SpkrRight IN", "WSA_SPK2 OUT",
>> +		"VA DMIC0", "vdd-micb",
>> +		"VA DMIC1", "vdd-micb",
>> +		"VA DMIC2", "vdd-micb",
>> +		"VA DMIC3", "vdd-micb";
>> +
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +	wsa-dai-link {
>> +		link-name = "WSA Playback";
>> +
>> +		codec {
>> +			sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
>> +					<&lpass_wsa_macro 0>;
> 
> Please align the <s
Ack>
> Konrad