linux-kernel - Re: [patch V2 09/45] genirq/cpuhotplug: Convert to lock guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7qbkmzo.ffs@tglx>
Date: Thu, 08 May 2025 19:53:31 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Marek Szyprowski <m.szyprowski@...sung.com>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch V2 09/45] genirq/cpuhotplug: Convert to lock guards

On Thu, May 08 2025 at 16:56, Marek Szyprowski wrote:
>>   	irq_lock_sparse();
>>   	for_each_active_irq(irq) {
>>   		desc = irq_to_desc(irq);
>> -		raw_spin_lock_irq(&desc->lock);
>> -		irq_restore_affinity_of_irq(desc, cpu);
>> -		raw_spin_unlock_irq(&desc->lock);
>> +		scoped_guard(raw_spinlock, &desc->lock)
>
> The above should be "scoped_guard(raw_spinlock_irq, &desc->lock)", otherwise the cpu hotplug is broken as in today's linux-next.

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=irq/core&id=c855506257063f444044d0a85a2e9ad9ab1c7ecd