linux-kernel - Re: [PATCH] of: unittest: Unlock on error in unittest_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f51e79bd585701e5bea713b280414ee@kernel.org>
Date: Thu, 08 May 2025 11:27:04 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>, Frank Rowand <frowand.list@...il.com>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] of: unittest: Unlock on error in unittest_data_add()

Quoting Dan Carpenter (2025-04-30 01:05:40)
> The of_overlay_mutex_unlock() was accidentally deleted if "of_root" is
> NULL.  Change this to a goto unlock.
> 
> Fixes: d1eabd218ede ("of: unittest: treat missing of_root as error instead of fixing up")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>