linux-kernel - Re: [PATCH][next] iio: admv1013: replace redundant ternary operator with just len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250508201348.61494209@jic23-huawei>
Date: Thu, 8 May 2025 20:13:48 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Colin Ian King <colin.i.king@...il.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
 Antoniu Miclaus <antoniu.miclaus@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] iio: admv1013: replace redundant ternary operator
 with just len

On Wed, 7 May 2025 08:49:46 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 5/7/25 8:45 AM, Colin Ian King wrote:
> > The variable ret is being assigned a return value and non-zero error
> > return paths are taken at all stages. At the end of the function ret
> > is always zero, so the ternary operator checking for zero ret is
> > redundant and can be replaced with just len instead.
> > 
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> > ---  
> 
> Reviewed-by: David Lechner <dlechner@...libre.com>
> 

Applied.