linux-kernel - Re: [PATCH v6 2/6] soc: spacemit: create a header for clock/reset registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBwwBSfnkw6XUOLA@ketchup>
Date: Thu, 8 May 2025 04:16:05 +0000
From: Haylen Chu <heylenay@....org>
To: Alex Elder <elder@...cstar.com>, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
	p.zabel@...gutronix.de, paul.walmsley@...ive.com,
	palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
	dlan@...too.org
Cc: inochiama@...look.com, guodong@...cstar.com, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, spacemit@...ts.linux.dev,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/6] soc: spacemit: create a header for clock/reset
 registers

On Tue, May 06, 2025 at 04:06:33PM -0500, Alex Elder wrote:
> Move the definitions of register offsets and fields used by the SpacemiT
> K1 SoC CCUs into a separate header file, so that they can be shared by
> the reset driver that will be found under drivers/reset.
> 
> Signed-off-by: Alex Elder <elder@...cstar.com>
> ---
>  drivers/clk/spacemit/ccu-k1.c | 111 +--------------------------------
>  include/soc/spacemit/ccu_k1.h | 113 ++++++++++++++++++++++++++++++++++

CCU is abbreviated from "clock controller unit" thus the filename seems
a little strange to me. Will k1-syscon.h be a better name? We could put
all syscon registers together when introducing the power-domain driver
later, which could provide an overall view of register layout.

>  2 files changed, 114 insertions(+), 110 deletions(-)
>  create mode 100644 include/soc/spacemit/ccu_k1.h

Best regards,
Haylen Chu