linux-kernel - Re: [PATCH v3 1/4] mm/page_isolation: make page isolation a standalone bit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250508211357.GE323143@cmpxchg.org>
Date: Thu, 8 May 2025 17:13:57 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Zi Yan <ziy@...dia.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	David Hildenbrand <david@...hat.com>,
	Oscar Salvador <osalvador@...e.de>,
	Vlastimil Babka <vbabka@...e.cz>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	Brendan Jackman <jackmanb@...gle.com>,
	Richard Chang <richardycc@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] mm/page_isolation: make page isolation a
 standalone bit.

On Thu, May 08, 2025 at 04:22:43PM -0400, Zi Yan wrote:
> On 7 May 2025, at 17:10, Zi Yan wrote:
> 
> > During page isolation, the original migratetype is overwritten, since
> > MIGRATE_* are enums and stored in pageblock bitmaps. Change
> > MIGRATE_ISOLATE to be stored a standalone bit, PB_migrate_isolate, like
> > PB_migrate_skip, so that migratetype is not lost during pageblock
> > isolation. pageblock bits needs to be word aligned, so expand
> > the number of pageblock bits from 4 to 8 and make PB_migrate_isolate bit 7.
> >
> > Signed-off-by: Zi Yan <ziy@...dia.com>

Acked-by: Johannes Weiner <hannes@...xchg.org>

> > ---
> >  include/linux/mmzone.h          | 17 ++++++++++----
> >  include/linux/page-isolation.h  |  2 +-
> >  include/linux/pageblock-flags.h | 33 +++++++++++++++++++++++++-
> >  mm/page_alloc.c                 | 41 ++++++++++++++++++++++++++++++++-
> >  4 files changed, 86 insertions(+), 7 deletions(-)
> >
> 
> Here is the fixup 1/3 to address Johannes’ comments.

Thanks!