linux-kernel - Re: [tip: perf/core] perf: Fix irq work dereferencing garbage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB0lnW68rLDtuCkZ@pavilion.home>
Date: Thu, 8 May 2025 23:43:57 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
	x86@...nel.org
Subject: Re: [tip: perf/core] perf: Fix irq work dereferencing garbage

Le Thu, May 08, 2025 at 09:46:05PM +0200, Peter Zijlstra a écrit :
> On Thu, May 08, 2025 at 09:11:23PM +0200, Frederic Weisbecker wrote:
> > Le Thu, May 08, 2025 at 10:34:29AM -0000, tip-bot2 for Frederic Weisbecker a écrit :
> > > The following commit has been merged into the perf/core branch of tip:
> > > 
> > > Commit-ID:     88d51e795539acd08bce028eff3aa78748b847a8
> > > Gitweb:        https://git.kernel.org/tip/88d51e795539acd08bce028eff3aa78748b847a8
> > > Author:        Frederic Weisbecker <frederic@...nel.org>
> > > AuthorDate:    Mon, 28 Apr 2025 13:11:47 +02:00
> > > Committer:     Peter Zijlstra <peterz@...radead.org>
> > > CommitterDate: Fri, 02 May 2025 12:40:40 +02:00
> > > 
> > > perf: Fix irq work dereferencing garbage
> > > 
> > > The following commit:
> > > 
> > > 	da916e96e2de ("perf: Make perf_pmu_unregister() useable")
> > > 
> > > has introduced two significant event's parent lifecycle changes:
> > > 
> > > 1) An event that has exited now has EVENT_TOMBSTONE as a parent.
> > >    This can result in a situation where the delayed wakeup irq_work can
> > >    accidentally dereference EVENT_TOMBSTONE on:
> > > 
> > > CPU 0                                          CPU 1
> > 
> > This is missing the most important (and boring) part of the changelog :-)
> > 
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > 
> > And I suspect some automatic check will also yell at some point at missing Sob.
> 
> Doh, script fail :/
> 
> Let me go fix.

Looks good, thanks!

-- 
Frederic Weisbecker
SUSE Labs