linux-kernel - Re: [PATCH net-next] net: mvpp2: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5844d56d-ebea-4a21-8c5d-8eb2318fffdb@linux.dev>
Date: Thu, 8 May 2025 23:56:44 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc: Köry Maincent <kory.maincent@...tlin.com>,
 Marcin Wojtas <marcin.s.wojtas@...il.com>,
 Russell King <linux@...linux.org.uk>, Claudiu Manoil
 <claudiu.manoil@....com>, Andrew Lunn <andrew@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Richard Cochran <richardcochran@...il.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: mvpp2: convert to ndo_hwtstamp_get() and
 ndo_hwtstamp_set()

On 08/05/2025 15:46, Vladimir Oltean wrote:
> New timestamping API was introduced in commit 66f7223039c0 ("net: add
> NDOs for configuring hardware timestamping") from kernel v6.6. It is
> time to convert the mvpp2 driver to the new API, so that the
> ndo_eth_ioctl() path can be removed completely.
> 
> Note that on the !port->hwtstamp condition, the old code used to fall
> through in mvpp2_ioctl(), and return either -ENOTSUPP if !port->phylink,
> or -EOPNOTSUPP, in phylink_mii_ioctl(). Keep the test for port->hwtstamp
> in the newly introduced net_device_ops, but consolidate the error code
> to just -EOPNOTSUPP. The other one is documented as NFS-specific, it's
> best to avoid it anyway.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>