linux-kernel - Re: [PATCH net-next V8 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250507174709.5790852a@kernel.org>
Date: Wed, 7 May 2025 17:47:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Jiri Pirko <jiri@...dia.com>, Gal Pressman
 <gal@...dia.com>, "Leon Romanovsky" <leonro@...dia.com>, Donald Hunter
 <donald.hunter@...il.com>, "Jiri Pirko" <jiri@...nulli.us>, Jonathan Corbet
 <corbet@....net>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, Moshe Shemesh <moshe@...dia.com>, Mark Bloch
 <mbloch@...dia.com>, Carolina Jubran <cjubran@...dia.com>, Cosmin Ratiu
 <cratiu@...dia.com>
Subject: Re: [PATCH net-next V8 1/5] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On Tue, 6 May 2025 14:26:39 +0300 Tariq Toukan wrote:
> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
> index bd9726269b4f..64b6aaa02047 100644
> --- a/Documentation/netlink/specs/devlink.yaml
> +++ b/Documentation/netlink/specs/devlink.yaml
> @@ -202,6 +202,11 @@ definitions:
>          name: exception
>        -
>          name: control
> +  -
> +    name:  devlink-rate-tc-index-max
> +    header: net/devlink.h
> +    type: const
> +    value: 7

The spec is for uAPI, but you're declaring a value which is only known
to the kernel.. What is the thinking here? It can't stay as is, it
breaks the build for user space, since there is no user space header
under net/devlink.h
-- 
pw-bot: cr