linux-kernel - Re: [PATCH] usb: quirks: Add NO_LPM quirk for SanDisk Extreme 55AE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025050825-census-slum-6f37@gregkh>
Date: Thu, 8 May 2025 07:27:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Jiayi Li <lijiayi@...inos.cn>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: quirks: Add NO_LPM quirk for SanDisk Extreme 55AE

On Thu, May 08, 2025 at 11:31:23AM +0800, Jiayi Li wrote:
> This device exhibits I/O errors during file transfers due to unstable
> link power management (LPM) behavior. The kernel logs show repeated
> warm resets and eventual disconnection when LPM is enabled:
> 
> [ 3467.810740] hub 2-0:1.0: state 7 ports 6 chg 0000 evt 0020
> [ 3467.810740] usb usb2-port5: do warm reset
> [ 3467.866444] usb usb2-port5: not warm reset yet, waiting 50ms
> [ 3467.907407] sd 0:0:0:0: [sda] tag#12 sense submit err -19
> [ 3467.994423] usb usb2-port5: status 02c0, change 0001, 10.0 Gb/s
> [ 3467.994453] usb 2-5: USB disconnect, device number 4
> 
> The error -19 (ENODEV) occurs when the device disappears during write
> operations. Adding USB_QUIRK_NO_LPM disables link power management
> for this specific device, resolving the stability issues.
> 
> Signed-off-by: Jiayi Li <lijiayi@...inos.cn>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 36d3df7d040c..2bb70a34d4c5 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -372,6 +372,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* SanDisk Corp. SanDisk 3.2Gen1 */
>  	{ USB_DEVICE(0x0781, 0x55a3), .driver_info = USB_QUIRK_DELAY_INIT },
>  
> +	/* SanDisk Extreme 55AE */
> +        { USB_DEVICE(0x0781, 0x55ae), .driver_info = USB_QUIRK_NO_LPM },

Nit, you forgot to use a tab here :(

I think scripts/checkpatch.pl should have caught this, right?

thanks,

greg k-h