[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fbftgni67wha2c6zdx3w5ccsxwlrr5yog6ifipkr4ft7h3hezo@kwb66muoctdj>
Date: Thu, 8 May 2025 15:33:17 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Christoph Hellwig <hch@...radead.org>,
Yosry Ahmed <yosry.ahmed@...ux.dev>, Vitaly Wool <vitaly.wool@...sulko.se>, linux-mm@...ck.org,
akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Nhat Pham <nphamcs@...il.com>,
Shakeel Butt <shakeel.butt@...ux.dev>, Johannes Weiner <hannes@...xchg.org>,
Minchan Kim <minchan@...nel.org>, Igor Belousov <igor.b@...dev.am>,
Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] mm/zblock: use vmalloc for page allocations
On (25/05/08 15:17), Sergey Senozhatsky wrote:
> On (25/05/07 23:00), Christoph Hellwig wrote:
> > On Thu, May 08, 2025 at 02:58:14PM +0900, Sergey Senozhatsky wrote:
> > > Oh, I didn't realize that zram was the only swap_slot_free_notify
> > > user. zram already handles REQ_OP_DISCARD/REQ_OP_WRITE_ZEROES so
> > > I guess only swap-cluster needs some work. Are there any
> > > blockers/complications on the swap-cluster side?
> >
> > I think the reason it was added it was so that the discard can be
> > done non-blocking with a spinlock held. Which seems a bit sketch
> > when calling into a driver anyway..
>
> swap_slot_free_notify is not guaranteed to free anything on the zram/zsmalloc
> side. zram attempts to trylock entry
.. I keep forgetting that slot-free can be called from an IRQ. That's
some complication.
Powered by blists - more mailing lists