[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aBxR2nnW1GZ7dN__@stanley.mountain>
Date: Thu, 8 May 2025 09:40:26 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>,
Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
stable@...r.kernel.org, patches@...ts.linux.dev,
torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
f.fainelli@...il.com, sudipm.mukherjee@...il.com,
srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
hargar@...rosoft.com, broonie@...nel.org,
Arnd Bergmann <arnd@...db.de>, Liam Girdwood <lgirdwood@...il.com>,
Frieder Schrempf <frieder.schrempf@...tron.de>,
Marek Vasut <marex@...x.de>,
Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH] rpmsg: qcom_smd: Fix uninitialized return variable in
__qcom_smd_send()
Hi Greg,
I'm sorry I forgot to add the:
Cc: stable@...r.kernel.org
to this patch. Could we backport it to stable, please?
regards,
dan carpenter
On Wed, Apr 23, 2025 at 08:22:05PM +0300, Dan Carpenter wrote:
> The "ret" variable isn't initialized if we don't enter the loop. For
> example, if "channel->state" is not SMD_CHANNEL_OPENED.
>
> Fixes: 33e3820dda88 ("rpmsg: smd: Use spinlock in tx path")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> Naresh, could you test this patch and see if it fixes the boot
> problems you saw?
>
> drivers/rpmsg/qcom_smd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 40d386809d6b..bb161def3175 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -746,7 +746,7 @@ static int __qcom_smd_send(struct qcom_smd_channel *channel, const void *data,
> __le32 hdr[5] = { cpu_to_le32(len), };
> int tlen = sizeof(hdr) + len;
> unsigned long flags;
> - int ret;
> + int ret = 0;
>
> /* Word aligned channels only accept word size aligned data */
> if (channel->info_word && len % 4)
> --
> 2.47.2
Powered by blists - more mailing lists