linux-kernel - Re: [PATCH 1/1] arm64: Kconfig: Enable PINCTRL on i.MX platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikmby52x.fsf@geanix.com>
Date: Thu, 08 May 2025 08:44:22 +0200
From: Esben Haabendal <esben@...nix.com>
To: "Alexander Stein" <alexander.stein@...tq-group.com>
Cc: "Catalin Marinas" <catalin.marinas@....com>,  "Will Deacon"
 <will@...nel.org>,  "Stefan Wahren" <wahrenst@....net>,
  <linux-arm-kernel@...ts.infradead.org>,  <linux-kernel@...r.kernel.org>,
  "Shawn Guo" <shawnguo@...nel.org>
Subject: Re: [PATCH 1/1] arm64: Kconfig: Enable PINCTRL on i.MX platforms

"Alexander Stein" <alexander.stein@...tq-group.com> writes:

> Hi Stefan,
>
> Am Mittwoch, 7. Mai 2025, 16:30:33 CEST schrieb Stefan Wahren:
>> Hi Alexander,
>>
>> [add Shawn and Esben]
>>
>> Am 07.05.25 um 14:44 schrieb Alexander Stein:
>> > Select PINCTRL for NXP i.MX SoCs.
>> could you please explain the motivation behind your change?
>>
>> Is it related to this commit 17d21001891402 ("ARM: imx: Allow user to
>> disable pinctrl")?
>
> Ah, thanks for the pointer. It might be the case.

The goal of the patch mentioned above was to be able to build a kernel
for LS1021A without pinctrl framework enabled, as LS1021A does not have
a pinctrl driver.

With your patch, that would not be possible anymore.

> I noticed that, when using arch/arm64/defconfig and disabling all
> platforms despite ARCH_MXC before running make olddefconfig,
> CONFIG_PINCTRL gets disabled as well. No platform is enabling it. I
> noticed this when building in yocto and non-IMX platforms are disabled
> for build time reasons.

But is that something that needs to be fixed?

It sounds like quite a special use-case, and why not simply enable
CONFIG_PINCTRL in that case then?

/Esben

>> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
>> > ---
>> >   arch/arm64/Kconfig.platforms | 1 +
>> >   1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> > index a541bb029aa4e..49c3bc25e5f68 100644
>> > --- a/arch/arm64/Kconfig.platforms
>> > +++ b/arch/arm64/Kconfig.platforms
>> > @@ -219,6 +219,7 @@ config ARCH_MXC
>> >   	select ARM64_ERRATUM_845719 if COMPAT
>> >   	select IMX_GPCV2
>> >   	select IMX_GPCV2_PM_DOMAINS
>> > +	select PINCTRL
>> >   	select PM
>> >   	select PM_GENERIC_DOMAINS
>> >   	select SOC_BUS