linux-kernel - Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBxo6nHlp92UjB4h@gcabiddu-mobl.ger.corp.intel.com>
Date: Thu, 8 May 2025 09:18:50 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Laurent M Coquerel <laurent.m.coquerel@...el.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
	George Abraham P <george.abraham.p@...el.com>, Suman Kumar Chakraborty
	<suman.kumar.chakraborty@...el.com>, Karthikeyan Gopal
	<karthikeyan.gopal@...el.com>, <qat-linux@...el.com>,
	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check
 in adf_probe()

Thanks Dan.

On Thu, May 08, 2025 at 09:26:25AM +0300, Dan Carpenter wrote:
> The pcim_iomap_region() returns error pointers.  It doesn't return NULL
> pointers.  Update the check to match.
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>