linux-kernel - Re: [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f88d35e2-c739-4432-a7fa-35c8a2dd2e9a@linux.alibaba.com>
Date: Thu, 8 May 2025 09:24:32 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: lukas@...ner.de, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-edac@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 helgaas@...nel.org, bhelgaas@...gle.com, tony.luck@...el.com, bp@...en8.de,
 mhiramat@...nel.org, mathieu.desnoyers@...icios.com, oleg@...hat.com,
 naveen@...nel.org, davem@...emloft.net, anil.s.keshavamurthy@...el.com,
 mark.rutland@....com, peterz@...radead.org, tianruidong@...ux.alibaba.com
Subject: Re: [PATCH v7] PCI: hotplug: Add a generic RAS tracepoint for hotplug
 event



在 2025/5/7 23:36, Steven Rostedt 写道:
> On Wed,  7 May 2025 09:15:35 +0800
> Shuai Xue <xueshuai@...ux.alibaba.com> wrote:
> 
>> +#endif /* _TRACE_HW_EVENT_PCI_HP_H */
>> +
>> +#undef TRACE_INCLUDE_PATH
>> +#define TRACE_INCLUDE_PATH  ../../drivers/pci/hotplug
> 
> Note, this is not always safe to do. If "drivers", "pci" or "hotplug" ever
> become a macro, the path will also be updated, and this will fail to build.
> 
>> +#undef TRACE_INCLUDE_FILE
>> +#define TRACE_INCLUDE_FILE trace
>> +
>> +/* This part must be outside protection */
>> +#include <trace/define_trace.h>
>> diff --git a/include/uapi/linux/pci.h b/include/uapi/linux/pci.h
> 
> The safer way to do this is to have:
> 
> In drivers/pci/hotplug/Makefile:
> 
> CFLAGS_pciehp_ctrl.o := -I$(src)
> 
> And replace the TRACE_INCLUDE_PATH to:
> 
> #define TRACE_INCLUDE_PATH .
> 
> -- Steve

Got it. Will fix it in next version.

Thanks.

Shuai