| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <f040a52e-51a8-4cea-afc1-7b3de259b067@rock-chips.com>
Date: Thu, 8 May 2025 16:33:13 +0800
From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Chaoyi Chen <kernel@...kyi.com>,
Sandy Huang <hjc@...k-chips.com>, Heiko Stuebner <heiko@...ech.de>,
Andy Yan <andy.yan@...k-chips.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: Dragan Simic <dsimic@...jaro.org>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: display: rockchip: Convert
cdn-dp-rockchip.txt to yaml
Hi Krzysztof,
On 2025/5/8 15:16, Krzysztof Kozlowski wrote:
> On 08/05/2025 08:43, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>>
>> Convert cdn-dp-rockchip.txt to yaml.
>>
>> Tested with:
>>
>> 1. make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml
>>
>> 2. make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml
> Drop. You do not have to embed in commit msg standard makefile targets.
> We all know how to use it. You do not do it for C files, do you?
Will drop it on v2.
>
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>> ---
> ...
>
>> - };
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml
>> new file mode 100644
>> index 000000000000..ed68b48a6743
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,cdn-dp.yaml
> Filename matching compatible.
Will change it in v2.
>
>> @@ -0,0 +1,148 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/rockchip/rockchip,cdn-dp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip RK3399 specific extensions to the CDN Display Port
>> +
>> +maintainers:
>> + - Andy Yan <andy.yan@...k-chip.com>
>> + - Heiko Stuebner <heiko@...ech.de>
>> + - Sandy Huang <hjc@...k-chips.com>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: rockchip,rk3399-cdn-dp
>> +
>> + reg:
>> + description:
>> + CDN DP core register
> Missing constraints. Drop description.
>
> Just look at other bindings.
Will fix in v2.
>
>> +
>> + assigned-clock-rates: true
>> + assigned-clocks: true
> Drop these two
>
>> +
>> + clocks:
>> + minItems: 4
> No, look at other bindings.
Will fix in v2.
>
>> +
>> + clock-names:
>> + items:
>> + - const: core-clk
>> + - const: pclk
>> + - const: spdif
>> + - const: grf
>> +
>> + extcon:
>> + description:
>> + Phandle to the extcon device providing the cable state for the DP phy.
> Missing type, unless you could not add a type because of conflicts? This
> should be really fixed...
Will add refs in v2.
>
>
>> +
>> + interrupts:
>> + maxItems: 1
> and here is maxItems. Why in other places you put minItems?
Sorry for that, I misunderstood the meaning of those filed. Will fix in v2.
>
>> +
>> + phys:
>> + minItems: 1
>> + maxItems: 2
> Why is this flexible? It wasn't in original binding and you must
> document all the changes done to the binding in commit msg.
I think the original binding had this. I will fix this in v2 and add
more description.
>
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Input of the CDN DP
>> + properties:
>> + endpoint@0:
>> + description: Connection to the VOPB
>> + endpoint@1:
>> + description: Connection to the VOPL
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Output of the CDN DP
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + resets:
>> + minItems: 4
> No, look at other bindings.
Will fix in v2.
>
>> +
>> + reset-names:
>> + items:
>> + - const: spdif
>> + - const: dptx
>> + - const: apb
>> + - const: core
>> +
>> + rockchip,grf:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + This SoC makes use of GRF regs.
> For what? You did not say anything useful above, so instead explain the
> purpose.
Will add more description in v2.
>
>> +
>> + "#sound-dai-cells":
>> + const: 1
> Missing dai-common ref, unless this is not a DAI?
Will add dai-common.yaml ref in v2.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - interrupts
>> + - phys
>> + - ports
>> + - resets
>> + - reset-names
>> + - rockchip,grf
>> +
>> +unevaluatedProperties: false
> Where is any $ref? additionalProperties instead or add proper ref
Will fix in v2.
>
>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/rk3399-cru.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/power/rk3399-power.h>
>> + cdn_dp: dp@...00000 {
> Drop unused label
Will drop it in v2.
Thanks for you fast reply!
Powered by blists - more mailing lists