linux-kernel - [PATCH 1/1] PCI/bwctrl: Remove also pcie_bwctrl_lbms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250508090036.1528-1-ilpo.jarvinen@linux.intel.com>
Date: Thu,  8 May 2025 12:00:36 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Paul E . McKenney" <paulmck@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Lukas Wunner <lukas@...ner.de>,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] PCI/bwctrl: Remove also pcie_bwctrl_lbms_rwsem

The commit 0238f352a63a ("PCI/bwctrl: Replace lbms_count with
PCI_LINK_LBMS_SEEN flag") remove all code related to
pcie_bwctrl_lbms_rwsem but forgot to remove the rwsem itself.
Remove it and the associated info from the comment now.

Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
---

Bjorn, this should be folded into the original commit I think.

 drivers/pci/pcie/bwctrl.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
index fdafa20e4587..f31fbbd51490 100644
--- a/drivers/pci/pcie/bwctrl.c
+++ b/drivers/pci/pcie/bwctrl.c
@@ -45,15 +45,7 @@ struct pcie_bwctrl_data {
 	struct thermal_cooling_device *cdev;
 };
 
-/*
- * Prevent port removal during LBMS count accessors and Link Speed changes.
- *
- * These have to be differentiated because pcie_bwctrl_change_speed() calls
- * pcie_retrain_link() which uses LBMS count reset accessor on success
- * (using just one rwsem triggers "possible recursive locking detected"
- * warning).
- */
-static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
+/* Prevent port removal during Link Speed changes. */
 static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
 
 static bool pcie_valid_speed(enum pci_bus_speed speed)

base-commit: 0238f352a63a075ac1f35ea565b5bec3057ec8bd
-- 
2.39.5