linux-kernel - Re: [PATCH -v2] accel/habanalabs: Don't build the driver on UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <709b486f4cfb93e0feac12300e4f06a34f49fd27.camel@sipsolutions.net>
Date: Thu, 08 May 2025 11:02:17 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Ingo Molnar <mingo@...nel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
 "linux-tip-commits@...r.kernel.org"
	 <linux-tip-commits@...r.kernel.org>, lkp <lkp@...el.com>, "x86@...nel.org"
	 <x86@...nel.org>, linux-um@...ts.infradead.org
Subject: Re: [PATCH -v2] accel/habanalabs: Don't build the driver on UML

On Thu, 2025-05-08 at 10:57 +0200, Ingo Molnar wrote:
> > 
> > I dunno. I guess we can put rdtsc() into UML on x86 as I suggested about
> > the file placement, or we can also just fix the Kconfig there.
> 
> The Kconfig solution looks much simpler to me too :)
> 
> Patch attached, does this look good to you?

Yeah looks good to me. Common gotcha really.

Reviewed-by: Johannes Berg <johannes@...solutions.net>

If anyone _really_ needs to have this driver built on UML (say for
simulations/testing, we do build iwlwifi for all the time), then they'd
probably want to replace the rdtsc() anyway with something else there.

johannes