[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025050854-breeching-had-c9b3@gregkh>
Date: Thu, 8 May 2025 11:45:20 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Zongmin Zhou <min_halo@....com>
Cc: rafael@...nel.org, dakr@...nel.org, markgross@...nel.org, arnd@...db.de,
eric.piel@...mplin-utc.net, valentina.manea.m@...il.com,
shuah@...nel.org, i@...ithal.me, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, Zongmin Zhou <zhouzongmin@...inos.cn>
Subject: Re: [PATCH 1/2] driver core:add device's platform_data set for faux
device
On Thu, May 08, 2025 at 05:11:47PM +0800, Zongmin Zhou wrote:
> From: Zongmin Zhou <zhouzongmin@...inos.cn>
>
> Most drivers based on platform bus may have specific data
> for the device.And will get this specific data to use
> after device added.
> So keep the setting for device's platform_data is necessary
> for converting platform device to faux device.
I do not understand, why not just use the platform_data field directly
in the faux device structure? Why change all callers to now have to
keep track of an additional pointer in these create functions? That
just adds complexity for everyone when almost no one will need it.
thanks,
greg k-h
Powered by blists - more mailing lists