linux-kernel - Re: [PATCH 4/6] f2fs: always unlock the page in f2fs_write_single_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2d58d5c-54fa-4b50-97cf-bb7876e1bbab@kernel.org>
Date: Thu, 8 May 2025 17:48:55 +0800
From: Chao Yu <chao@...nel.org>
To: Christoph Hellwig <hch@....de>, Jaegeuk Kim <jaegeuk@...nel.org>
Cc: chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] f2fs: always unlock the page in
 f2fs_write_single_data_page

On 5/8/25 13:14, Christoph Hellwig wrote:
> Consolidate the code to unlock the page in f2fs_write_single_data_page
> instead of leaving it to the callers for the AOP_WRITEPAGE_ACTIVATE case.
> Replace AOP_WRITEPAGE_ACTIVATE with a positive return of 1 as this case
> now doesn't match the historic ->writepage special return code that is
> on it's way out now that ->writepage has been removed.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,