linux-kernel - Re: [PATCH v2 2/2] i2c: i801: don't instantiate spd5118 under SPD Write Disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <p7y5i2zzwnej4znzly7h42r4p7f3xkhbe2pamkfktu2j5jts3o@sm75wirr4tkq>
Date: Thu, 8 May 2025 12:33:50 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: "Yo-Jung (Leo) Lin" <leo.lin@...onical.com>
Cc: Jean Delvare <jdelvare@...e.com>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Guenter Roeck <linux@...ck-us.net>, 
	"Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: i801: don't instantiate spd5118 under SPD
 Write Disable

Hi Yo-Jung,

On Wed, May 07, 2025 at 10:50:10AM +0200, Yo-Jung (Leo) Lin wrote:
> On Tue, May 6, 2025 at 1:53 PM Andi Shyti <andi.shyti@...nel.org> wrote:
> 
>     ...
> 
>     > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/
>     i2c-i801.c
>     > index a7f89946dad4..88474409e82d 100644
>     > --- a/drivers/i2c/busses/i2c-i801.c
>     > +++ b/drivers/i2c/busses/i2c-i801.c
>     > @@ -1177,10 +1177,12 @@ static void i801_probe_optional_targets(struct
>     i801_priv *priv)
>     >               dmi_walk(dmi_check_onboard_devices, &priv->adapter);
>     > 
>     >       /* Instantiate SPD EEPROMs unless the SMBus is multiplexed */
>     > -#ifdef CONFIG_I2C_I801_MUX
>     > -     if (!priv->mux_pdev)
>     > -#endif
>     > -             i2c_register_spd_write_enable(&priv->adapter);
>     > +     if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {
> 
>     this if is not really working and it has been reported the
>     following compile error:
> 
>     drivers/i2c/busses/i2c-i801.c: In function 'i801_probe_optional_targets':
>     drivers/i2c/busses/i2c-i801.c:1180:54: error: 'struct i801_priv' has no
>     member named 'mux_pdev'
>      1180 |         if (!IS_ENABLED(CONFIG_I2C_I801_MUX) || !priv->mux_pdev) {
>           |
> 
>     Therefore I'm going to revert just this patch 2/2. Please do
>     resubmit it and please test it properly with the
>     CONFIG_I2C_I801_MUX enabled and disabled.
> 
> 
> Sorry for all the troubles. Will try to propose another patch that takes this
> into consideration. 

don't worry, it happens, that's why we test at different levels ;-)

Andi