linux-kernel - Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a57ns7oh.fsf@minerva.mail-host-address-is-not-set>
Date: Thu, 08 May 2025 12:44:46 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Philipp Stanner <phasta@...lbox.org>, Philipp Stanner
 <phasta@...nel.org>, Dave Airlie <airlied@...hat.com>, Gerd Hoffmann
 <kraxel@...hat.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Alex Deucher <alexander.deucher@....com>,
 Arnd Bergmann <arnd@...nel.org>, Jani Nikula <jani.nikula@...el.com>,
 Niklas Schnelle <schnelle@...ux.ibm.com>, Jeff Johnson
 <jeff.johnson@....qualcomm.com>
Cc: virtualization@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

Philipp Stanner <phasta@...lbox.org> writes:

Hello Philipp,

> On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
>> Philipp Stanner <phasta@...nel.org> writes:
>> 
>> Hello Philipp,
>> 
>> > cirrus enables its PCI device with pcim_enable_device(). This,
>> > implicitly, switches the function pci_request_regions() into
>> > managed
>> > mode, where it becomes a devres function.
>> > 
>> > The PCI subsystem wants to remove this hybrid nature from its
>> > interfaces. To do so, users of the aforementioned combination of
>> > functions must be ported to non-hybrid functions.
>> > 
>> > Replace the call to sometimes-managed pci_request_regions() with
>> > one to
>> > the always-managed pcim_request_all_regions().
>> > 
>> > Signed-off-by: Philipp Stanner <phasta@...nel.org>
>> > ---
>> 
>> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
>> 
>
> Who's in charge of applying this? Any objections with me just putting
> it into drm-misc-next?
>

Sure, go ahead.

> P.
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat