linux-kernel - Re: [PATCH v6 3/3] PCI: tegra: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ8899t0BYMgn1a3iDKz_J9z_Wv_XYM2d8Y4AoiXPZaFjA@mail.gmail.com>
Date: Thu, 8 May 2025 06:26:39 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 3/3] PCI: tegra: Allow building as a module

On Thu, May 8, 2025 at 3:40 AM Thierry Reding <thierry.reding@...il.com> wrote:
>
> On Wed, May 07, 2025 at 10:25:54PM -0500, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@...il.com>
> >
> > This changes the module macro back to builtin, which does not define an
> > exit function. This will prevent the module from being unloaded. There
> > are concerns with modules not cleaning up IRQs on unload, thus this
> > needs specifically disallowed. The remove callback is also dropped as it
> > is unused.
>
> What exactly are these concerns? I haven't done this lately, but I'm
> pretty sure that unbinding the PCI controller is something that I
> extensively tested back when this code was introduced. PCI is designed
> to be hot-pluggable, so there shouldn't be a need to prevent unloading
> of the controller.
>
> Rather than just forcing this to be always there, can we not fix any
> issues and keep this unloadable?

For the short version, see this part of the conversation on v1 [0].
For the long version, read comments on all revisions. Basically, I
originally submitted this as unloadable, but got told that due to
generic concerns that affect all pci drivers, including ones already
modules and unloadable, making this one a module would be blocked if
it was unloadable. Which leads us to this revision of the series.

Sincerely,
Aaron

[0] https://lore.kernel.org/all/4u4h27w77sdjvy43b3yonidhfjuvljylms3qxqfaqwyw3v32qo@kzgrrenxr6yz/