linux-kernel - Re: [PATCH v2 2/5] dt-bindings: iio: magnetometer: qst: Add QMC5883L device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32b295ae-4186-4d37-9bfb-15b81afaa5ec@kernel.org>
Date: Thu, 8 May 2025 14:16:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Brajesh Patil <brajeshpatil11@...il.com>, jic23@...nel.org,
 lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, marcelo.schmitt1@...il.com,
 dlechner@...libre.com
Subject: Re: [PATCH v2 2/5] dt-bindings: iio: magnetometer: qst: Add QMC5883L
 device tree binding

On 08/05/2025 14:08, Brajesh Patil wrote:
> Signed-off-by: Brajesh Patil <brajeshpatil11@...il.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

...

> +
> +  mount-matrix:
> +    description: |
> +      A 3x3 rotation matrix describing how the magnetometer is mounted
> +      on the device. This is used to orient the sensor measurements
> +      to match the device's coordinate system.
No supplies?

Best regards,
Krzysztof