linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-j722s-evm: Add overlay for TEVI OV5640

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250508124406.tb34bqhv66gqcb7j@swizzle>
Date: Thu, 8 May 2025 07:44:06 -0500
From: Nishanth Menon <nm@...com>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>
CC: "Kumar, Udit" <u-kumar1@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vaishnav.a@...com>, <r-donadkar@...com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <jai.luthra@...ux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j722s-evm: Add overlay for TEVI
 OV5640

On 17:46-20250508, Yemike Abhilash Chandra wrote:
> Hi Udit,
> Thanks for the review.
> 
> On 07/05/25 13:50, Kumar, Udit wrote:
> > Hello Vaishnav/Abhilash
> > 
> > Thanks for patch
> > 
> > On 5/5/2025 5:27 PM, Yemike Abhilash Chandra wrote:
> > > From: Vaishnav Achath <vaishnav.a@...com>
> > > 
> > > TechNexion TEVI OV5640 camera is a 5MP camera that can be used with
> > > J722S EVM through the 22-pin CSI-RX connector. Add a reference overlay
> > > for quad TEVI OV5640 modules on J722S EVM.
> > > 
> > > Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
> > > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>
> > > ---
> > >   arch/arm64/boot/dts/ti/Makefile               |   4 +
> > >   .../k3-j722s-evm-csi2-quad-tevi-ov5640.dtso   | 358 ++++++++++++++++++
> > >   2 files changed, 362 insertions(+)
> > >   create mode 100644
> > > arch/arm64/boot/dts/ti/k3-j722s-evm-csi2-quad-tevi-ov5640.dtso
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/Makefile
> > > b/arch/arm64/boot/dts/ti/Makefile
> > > index 829a3b028466..76b750e4b8a8 100644
> > > --- a/arch/arm64/boot/dts/ti/Makefile
> > > +++ b/arch/arm64/boot/dts/ti/Makefile
> > > @@ -123,6 +123,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-pcie1-ep.dtbo
> > >   dtb-$(CONFIG_ARCH_K3) += k3-am67a-beagley-ai.dtb
> > >   dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
> > >   dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm-csi2-quad-rpi-cam-imx219.dtbo
> > > [..]
> > > diff --git
> > > a/arch/arm64/boot/dts/ti/k3-j722s-evm-csi2-quad-tevi-ov5640.dtso
> > > b/arch/arm64/boot/dts/ti/k3-j722s-evm-csi2-quad-tevi-ov5640.dtso
> > > new file mode 100644
> > > index 000000000000..537224ea60e3
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-csi2-quad-tevi-ov5640.dtso
> > > @@ -0,0 +1,358 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> > > +/*
> > > + * 4 x TEVI OV5640 MIPI Camera module on RPI camera connector.
> > > + *
> > > + * Copyright (C) 2024 Texas Instruments Incorporated -
> > > https://www.ti.com/
> > > + */
> > > +
> > > +/dts-v1/;
> > > +/plugin/;
> > > +
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include "k3-pinctrl.h"
> > > +
> > > +&{/} {
> > > +    clk_ov5640_fixed: clock-24000000 {
> > > +        compatible = "fixed-clock";
> > > +        #clock-cells = <0>;
> > > +        clock-frequency = <24000000>;
> > > +    };
> > > +
> > 
> > Please check once , this is clock is 25M or 24M .
> > 
> > As I see CDC6CE025000ADLXT/U28 is marked as 25M OSC
> > 
> 
> This is the crystal clock with in the sensor.

Please cross check this - the camera *module* has a BAW crystal which is the
source of clock to the sensor.


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D