linux-kernel - Re: [PATCH next] platform/x86: dasharo-acpi: Fix a couple off by one bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7dac833b-5a47-d168-38b9-ece2d5de2ae5@linux.intel.com>
Date: Thu, 8 May 2025 16:49:39 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
cc: Michał Kopeć <michal.kopec@...eb.com>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Thomas Weißschuh <linux@...ssschuh.net>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] platform/x86: dasharo-acpi: Fix a couple off by
 one bugs

On Wed, 7 May 2025, Dan Carpenter wrote:

> These two > comparisons should be >= to prevent reading beyond
> the end of the array.
> 
> Fixes: 2dd40523b7e2 ("platform/x86: Introduce dasharo-acpi platform driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/platform/x86/dasharo-acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/dasharo-acpi.c b/drivers/platform/x86/dasharo-acpi.c
> index f10f52e44641..f0c5136af29d 100644
> --- a/drivers/platform/x86/dasharo-acpi.c
> +++ b/drivers/platform/x86/dasharo-acpi.c
> @@ -101,10 +101,10 @@ static int dasharo_read_channel(struct dasharo_data *data, char *method, enum da
>  	acpi_status status;
>  	u64 val;
>  
> -	if (feat > ARRAY_SIZE(data->capabilities))
> +	if (feat >= ARRAY_SIZE(data->capabilities))
>  		return -EINVAL;
>  
> -	if (channel > data->caps_found[feat])
> +	if (channel >= data->caps_found[feat])
>  		return -EINVAL;
>  
>  	obj[0].type = ACPI_TYPE_INTEGER;
> 

Thanks Dan, I've folded this into the original commit as I was rewriting 
history anyway due to some other fixes.

-- 
 i.