linux-kernel - Re: [PATCH] nvme-pci: lock per namespace in nvme_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBy_qLi3OvYk6HAL@kbusch-mbp>
Date: Thu, 8 May 2025 08:28:56 -0600
From: Keith Busch <kbusch@...nel.org>
To: Daniel Wagner <wagi@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>, Hannes Reinecke <hare@...nel.org>,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: lock per namespace in nvme_poll_irqdisable

On Thu, May 08, 2025 at 01:55:55PM +0200, Daniel Wagner wrote:
> +	spin_lock(&nvmeq->cq_poll_lock);
>  	disable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
>  	nvme_poll_cq(nvmeq, NULL);
>  	enable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
> +	spin_unlock(&nvmeq->cq_poll_lock);
>  }

I noticed disable_irq() contains a "might_sleep()", so the order needs
to have spin_lock() happen after disable_irq().