linux-kernel - Re: [PATCH 2/2] platform/x86: export thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBzAWrgEgmnAnum-@smile.fi.intel.com>
Date: Thu, 8 May 2025 17:31:54 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, ikepanhc@...il.com,
	W_Armin@....de, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] platform/x86: export thinkpad_acpi handles

On Wed, May 07, 2025 at 03:04:35PM -0400, Mark Pearson wrote:
> Add API to be able to get the thinkpad_acpi various handles.
> 
> Will use this to start pulling some of the thinkpad_acpi functionality
> into separate modules in the future.

...

> +#ifndef _TP_ACPI_H_
> +#define _TP_ACPI_H_

+ include for  acpi_handle typedef.
Or it the forward declaration works

acpi_handle;

but I haven't checked and my gut feelings that it's not correct syntax as
compiler doesn't know what the heck this word means.

> +enum tp_acpi_handle_id {
> +	TP_ROOT_HANDLE,
> +	TP_EC_HANDLE,
> +	TP_HKEY_HANDLE,
> +};
> +
> +int tp_acpi_get_handle(enum tp_acpi_handle_id handle_id, acpi_handle *handle);
> +
> +#endif /* _TP_ACPI_H */

-- 
With Best Regards,
Andy Shevchenko