linux-kernel - Re: [PATCH] mm: remove useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cd1e38d-cc80-40ac-bb7a-ca45b37f45df@redhat.com>
Date: Thu, 8 May 2025 16:39:27 +0200
From: David Hildenbrand <david@...hat.com>
To: Barry Song <21cnbao@...il.com>
Cc: Feng Lee <379943137@...com>, akpm@...ux-foundation.org,
 ryan.roberts@....com, libang.li@...group.com, peterx@...hat.com,
 maobibo@...ngson.cn, lance.yang@...ux.dev, anshuman.khandual@....com,
 trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: remove useless code


>> Yeah, but this is GUP ... ("user") ... looks like that check/handling
>> was in there ever since git happened.
>>
>> get_gate_vma() only exists on x86-64 and uml.
>>
>> I wonder if that could ever actually reside > TASK_SIZE such that we
>> would even need that.
> 
> I assume that reside > TASK_SIZE can only be true on IA64?
> 
>   /* Look up a pgd entry in the gate area.  On IA-64, the gate-area
>        resides in the kernel-mapped segment, hence we use pgd_offset_k()
>        here.  */
> #define pgd_offset_gate(mm, addr) pgd_offset_k(addr)
> 
> Since IA64 is dead, is the code also dead? It seems we can safely move
> forward with the approach you're proposing.

Thanks for verifying!

-- 
Cheers,

David / dhildenb