[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250508-brethren-rants-a3c80c091b45@spud>
Date: Thu, 8 May 2025 15:41:52 +0100
From: Conor Dooley <conor@...nel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
Dragos Bogdan <dragos.bogdan@...log.com>,
Antoniu Miclaus <antoniu.miclaus@...log.com>,
Olivier Moysan <olivier.moysan@...s.st.com>,
Javier Carrasco <javier.carrasco.cruz@...il.com>,
Matti Vaittinen <mazziesaccount@...il.com>,
Tobias Sperling <tobias.sperling@...ting.com>,
Alisa-Dariana Roman <alisadariana@...il.com>,
Marcelo Schmitt <marcelo.schmitt@...log.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Ramona Alexandra Nechita <ramona.nechita@...log.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: iio: adc: add ad7405
On Thu, May 08, 2025 at 03:30:56PM +0300, Pop Ioan Daniel wrote:
> Add devicetree bindings for ad7405/adum770x family.
>
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> ---
> changes in v2:
> - remove #address-cells and #size-cells
> - add additionalProperties: false instead of unevaluatedProperties: false
> - remove #include <dt-bindings/interrupt-controller/irq.h>
> because it's not used
> - add new line at the end of the file
> - add mantainer
> .../bindings/iio/adc/adi,ad7405.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
> new file mode 100644
> index 000000000000..8c30a712968d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7405 family
> +
> +maintainers:
> + - Dragos Bogdan <dragos.bogdan@...log.com>
> + - Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> +
> +description: |
> + Analog Devices AD7405 is a high performance isolated ADC, 1-channel,
> + 16-bit with a second-order Σ-Δ modulator that converts an analog input signal
> + into a high speed, single-bit data stream.
> +
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7405.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7701.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7702.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADuM7703.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7405
> + - adi,adum7701
> + - adi,adum7702
> + - adi,adum7703
These last three devices have the same match data, why is a fallback
compatible not appropriate? (Please list the reason in your commit
message).
> +
> + vdd1-supply: true
> +
> + vdd2-supply: true
> +
> + clocks:
> + maxitems: 1
> +
> + io-backends:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - vdd1-supply
> + - vdd2-supply
> + - clocks
> + - io-backends
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + adc {
> + compatible = "adi,ad7405";
> + clocks = <&axi_clk_gen 0>;
> + vdd1-supply = <&vdd1>;
> + vdd2-supply = <&vdd2>;
> + io-backends = <&iio_backend>;
> + };
> +...
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists