linux-kernel - Re: [PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in a platform specific way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad737e02dd4b7958ecac1d67ac2f3da7a238d012.camel@gmail.com>
Date: Fri, 09 May 2025 12:59:40 +1000
From: Wilfred Mallawa <wilfred.opensource@...il.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Mahesh J
 Salgaonkar <mahesh@...ux.ibm.com>, Oliver O'Halloran <oohall@...il.com>,
 Bjorn Helgaas	 <bhelgaas@...gle.com>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, Krzysztof Wilczyński	
 <kw@...ux.com>, Rob Herring <robh@...nel.org>, Zhou Wang
 <wangzhou1@...ilicon.com>,  Will Deacon <will@...nel.org>, Robert Richter
 <rric@...nel.org>, Alyssa Rosenzweig <alyssa@...enzweig.io>,  Marc Zyngier
 <maz@...nel.org>, Conor Dooley <conor.dooley@...rochip.com>, Daire McNamara
	 <daire.mcnamara@...rochip.com>
Cc: dingwei@...vell.com, cassel@...nel.org, Lukas Wunner <lukas@...ner.de>, 
 Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
 linuxppc-dev@...ts.ozlabs.org, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in
 a platform specific way

On Thu, 2025-05-08 at 12:40 +0530, Manivannan Sadhasivam wrote:
> Some host bridge devices require resetting the slots in a platform
> specific
> way to recover them from error conditions such as Fatal AER errors,
> Link
> Down etc... So introduce pci_host_bridge::reset_slot callback and
> call it
> from pcibios_reset_secondary_bus() if available.
> 
> The 'reset_slot' callback is responsible for resetting the given slot
> referenced by the 'pci_dev' pointer in a platform specific way and
> bring it
> back to the working state if possible. If any error occurs during the
> slot
> reset operation, relevant errno should be returned.
> 
> Signed-off-by: Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org>
> 
Hey Manivannan,

I've been testing this by adding support for the reset_slot() callback
in the dw-rockchip driver. Which has now fixed issues with sysfs issued
bus resets to endpoints. So feel free to use:

Tested-by: Wilfred Mallawa <wilfred.mallawa@....com>

Regards,
Wilfred