[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250509142604.GF2492385@google.com>
Date: Fri, 9 May 2025 15:26:04 +0100
From: Lee Jones <lee@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Srinivas Kandagatla <srini@...nel.org>, Kees Cook <kees@...nel.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
Peter Griffin <peter.griffin@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-hardening@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v10 0/3] Maxim Integrated MAX77759 PMIC MFD-based drivers
On Fri, 09 May 2025, André Draszik wrote:
> Hi,
>
> This series improves support for the Maxim Integrated MAX77759
> companion PMIC for USB Type-C applications using the MFD framework.
>
> This series must be applied in-order, due to interdependencies of some
> of the patches:
> * to avoid use of undocumented compatibles by the newly added drivers,
> the bindings are added first in this series
> * patch 1 ("dt-bindings: gpio: add max77759 binding") also creates a
> new MAINTAINERS entry, including a wildcard match for the other
> bindings in this series
> * patch 3 ("dt-bindings: mfd: add max77759 binding") references the
> bindings added in patch 1 and 2 and can not work if those aren't
> available
> * patch 4 ("mfd: max77759: add Maxim MAX77759 core mfd driver") adds
> the core MFD driver, which also exposes an API to its leaf drivers
> and is used by patches 5 and 6
> * patches 5 and 6 won't compile without patch 4
>
> The MAX77759 PMIC includes Battery Charger, Fuel Gauge, temperature
> sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander.
>
> This PMIC is used on the Google Pixel 6 and 6 Pro (oriole / raven).
>
> This series adds support for the top-level MFD device, the gpio, and
> nvmem cells. Other components are excluded for the following reasons:
>
> While in the same package, Fuel Gauge and TCPC have separate and
> independent I2C addresses, register maps, interrupt lines, and
> aren't part of the top-level package interrupt hierarchy.
> Furthermore, a driver for the TCPC part exists already (in
> drivers/usb/typec/tcpm/tcpci_maxim_core.c).
>
> I'm leaving out temperature sensors and charger in this submission,
> because the former are not in use on Pixel 6 and I therefore can
> not test them, and the latter can be added later, once we look at
> the whole charging topic in more detail.
>
> To make maintainers' work easier, I am planning to send the relevant
> DTS and defconfig changes via a different series, unless everything
> is expected to go via Lee's MFD tree in one series?
>
> Cheers,
> Andre'
Okay, this (and the DT bindings) has been applied and submitted for
testing. Once successful, I'll get a PR out for the other maintainers
to pull from.
Note to self: ib-mfd-gpio-nvmem-6.16
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists