linux-kernel - Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250509081625.5d4589a5@kernel.org>
Date: Fri, 9 May 2025 08:16:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Jiri Pirko <jiri@...dia.com>, Gal Pressman
 <gal@...dia.com>, "Leon Romanovsky" <leonro@...dia.com>, Donald Hunter
 <donald.hunter@...il.com>, "Jiri Pirko" <jiri@...nulli.us>, Jonathan Corbet
 <corbet@....net>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, Moshe Shemesh <moshe@...dia.com>, Mark Bloch
 <mbloch@...dia.com>, Carolina Jubran <cjubran@...dia.com>, Cosmin Ratiu
 <cratiu@...dia.com>
Subject: Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On Fri, 9 May 2025 08:43:05 +0300 Tariq Toukan wrote:
> +  -
> +    name:  devlink-rate-tc-index-max
> +    header: uapi/linux/devlink.h
> +    type: const
> +    value: 7

Ugh, still wrong, the user space headers don't have uAPI in the path
when installed. They go to /usr/include/linux/$name.h
But for defines "local" to the family you don't have to specify header:
at all, just drop it.

And please do build tests the next version:

	make -C tools/net/ynl/ W=1 -j

I'm going to also give you a hint that my next complaint will be that
there are no selftests in this series, and it extends uAPI.
-- 
pw-bot: cr