linux-kernel - Re: [PATCH 2/2] arm64: dts: imx8mp: Add TechNexion EDM-G-IMX8M-PLUS SoM on WB-EDM-G carrier board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250509-dripping-colonial-aa805906a189@spud>
Date: Fri, 9 May 2025 16:44:18 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Richard Hu <richard.hu@...hnexion.com>, sascha.hauer@...gutronix.de,
	Shawn Guo <shawnguo@...nel.org>, imx@...ts.linux.dev,
	ray.chang@...hnexion.com, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Add TechNexion EDM-G-IMX8M-PLUS
 SoM on WB-EDM-G carrier board

On Fri, May 09, 2025 at 03:58:32PM +0200, Krzysztof Kozlowski wrote:
> On 09/05/2025 15:21, Krzysztof Kozlowski wrote:
> > 
> > No, that's not a spi controller.
> > 
> > Node names should be generic. See also an explanation and list of
> > examples (not exhaustive) in DT specification:
> > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> > 
> > 
> >> +		compatible = "rohm,dh2228fv";
> > 
> > I doubt that. Drop the node or fix the compatible.
> 
> ... especially that dh2228fv does not exist. There is no such device
> from ROHM. If you claim otherwise, please share this imaginary device
> datasheet.

To be clear, the thing to do if you have some device without a kernel
driver and want to use spidev for it, is to add a binding for the
device and add the device specific compatible to spidev.c.
If it is a simple device with no unusual properties (maybe it has an
interrupt, that's fine) add it to trivial-devices.yaml instead of
writing a dedicated binding.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)