linux-kernel - Re: [PATCH v1] perf trace: Fix some more memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB4jmGT8M8bJEY9c@google.com>
Date: Fri, 9 May 2025 08:47:36 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf trace: Fix some more memory leaks

On Thu, May 08, 2025 at 05:11:45PM -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, May 08, 2025 at 10:36:19AM -0700, Namhyung Kim wrote:
> > On Thu, May 08, 2025 at 11:52:08AM -0300, Arnaldo Carvalho de Melo wrote:
> > > On Tue, Apr 01, 2025 at 01:27:15PM -0700, Ian Rogers wrote:
> > > > The files.max is the maximum valid fd in the files array and so
> > > > freeing the values needs to be inclusive of the max value.
> > > > 
> > > > Add missing thread__put of the found parent thread in
> > > > thread__e_machine.
> > > 
> > > Split it into:
> > > 
> > > ⬢ [acme@...lbx perf-tools-next]$ git log --oneline -2
> > > 7900938850645ed4 (HEAD -> perf-tools-next) perf trace: Add missing thread__put() in thread__e_machine()
> > > 8830091383b03498 perf trace: Free the files.max entry in files->table
> > > ⬢ [acme@...lbx perf-tools-next]$ 
> > > 
> > > So that git --oneline is more descriptive, etc.
> > > 
> > > Thanks, applied to perf-tools-next,
> > 
> > PTAL this one as well.
> > 
> > https://lore.kernel.org/r/20250403054213.7021-1-namhyung@kernel.org
> 
> Split into two patches, as one fixes one long standing problem (from
> 2017:
> 
>     perf trace: Fix leaks of 'struct thread' in set_filter_loop_pids()
>     
>     I've found some leaks from 'perf trace -a'.
>     
>     It seems there are more leaks but this is what I can find for now.
>     
>     Fixes: 082ab9a18e532864 ("perf trace: Filter out 'sshd' in the tracer ancestry in syswide tracing")
> 
> But the other fixes a more recent bug:
> 
>     perf trace: Fix leaks of 'struct thread' in fprintf_sys_enter()
>     
>     I've found some leaks from 'perf trace -a'.
>     
>     It seems there are more leaks but this is what I can find for now.
>     
>     Fixes: 70351029b55677eb ("perf thread: Add support for reading the e_machine type for a thread")
> 
> - Arnaldo

Thanks for doing this!
Namhyung