linux-kernel - Re: [for-next][PATCH 16/31] tracing: Add tracer_tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Urs5yKCA38MgXOy7_LhV44-kT7tFGohtxSMzeeozjeDQ@mail.gmail.com>
Date: Fri, 9 May 2025 08:49:11 -0700
From: Doug Anderson <dianders@...omium.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Jason Wessel <jason.wessel@...driver.com>, 
	Daniel Thompson <danielt@...nel.org>
Subject: Re: [for-next][PATCH 16/31] tracing: Add tracer_tracing_disable/enable()
 functions

Hi,

On Fri, May 9, 2025 at 6:13 AM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> From: Steven Rostedt <rostedt@...dmis.org>
>
> Allow a tracer to disable writing to its buffer for a temporary amount of
> time and re-enable it.
>
> The tracer_tracing_disable() will disable writing to the trace array
> buffer, and requires a tracer_tracing_enable() to re-enable it.
>
> The difference between tracer_tracing_disable() and tracer_tracing_off()
> is that the disable version can nest, and requires as many enable() calls
> as disable() calls to re-enable the buffer. Where as the off() function
> can be called multiple times and only requires a singe tracer_tracing_on()
> to re-enable the buffer.
>
> Cc: Jason Wessel <jason.wessel@...driver.com>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Daniel Thompson <danielt@...nel.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Link: https://lore.kernel.org/20250505212235.210330010@goodmis.org
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  kernel/trace/trace.c | 33 +++++++++++++++++++++++++++++++++
>  kernel/trace/trace.h |  2 ++
>  2 files changed, 35 insertions(+)

I'm not deeply familiar with the tracing system internals, but it
seems reasonable to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>