linux-kernel - Re: [PATCH v3 3/3] fs: fuse: add more information to fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegs-tY8oebgc6YubXt-NCWA+gWEvu0yen0sAT8drM9Dghg@mail.gmail.com>
Date: Fri, 9 May 2025 18:05:51 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: chenlinxuan@...ontech.com
Cc: Amir Goldstein <amir73il@...il.com>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] fs: fuse: add more information to fdinfo

On Fri, 9 May 2025 at 08:34, Chen Linxuan via B4 Relay
<devnull+chenlinxuan.uniontech.com@...nel.org> wrote:

>  static const struct file_operations fuse_file_operations = {
>         .llseek         = fuse_file_llseek,
>         .read_iter      = fuse_file_read_iter,
> @@ -3411,6 +3428,9 @@ static const struct file_operations fuse_file_operations = {
>         .poll           = fuse_file_poll,
>         .fallocate      = fuse_file_fallocate,
>         .copy_file_range = fuse_copy_file_range,
> +#ifdef CONFIG_PROC_FS
> +       .show_fdinfo    = fuse_file_show_fdinfo,
> +#endif
>  };

The backing file mechanism is an internal implementation detail of
fuse and does not need to be displayed in the fuse file's fdinfo.
Currently we can only have one backing file per fuse file, but that
may well change in the future, as well as other details like offset
into the backing file (think FS_IOC_FIEMAP).

So NAK unless there's a very good use case for this.

Adding fdinfo for the /dev/fuse file is encouraged, it would be good
to be able to retrieve the connection number from the dev fd.

Thanks,
Miklos