linux-kernel - Re: [PATCH v4 6/9] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB4rliBFrUWWuNQ2@blossom>
Date: Fri, 9 May 2025 12:21:42 -0400
From: Alyssa Rosenzweig <alyssa@...enzweig.io>
To: Sven Peter <sven@...npeter.dev>
Cc: Janne Grunau <j@...nau.net>, Neal Gompa <neal@...pa.dev>,
	Hector Martin <marcan@...can.st>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sebastian Reichel <sre@...nel.org>, Lee Jones <lee@...nel.org>,
	Marc Zyngier <maz@...nel.org>,
	Russell King <rmk+kernel@...linux.org.uk>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 6/9] power: reset: macsmc-reboot: Add driver for
 rebooting via Apple SMC

> >
> >> +		mdelay(100);
> >> +		WARN_ON(1);
> >
> > ...What?
> 
> This is done in a few drivers in drivers/power/reboot. If we haven't
> rebooted after 100ms something's wrong with SMC. I'll add a comment.
> 
> drivers/power/reset/tps65086-restart.c:	WARN_ON(1);
> drivers/power/reset/atc260x-poweroff.c:	WARN_ONCE(1, "Unable to power off system\n");
> drivers/power/reset/mt6323-poweroff.c:	WARN_ONCE(1, "Unable to power off system\n");
> drivers/power/reset/gpio-restart.c:	WARN_ON(1);
> drivers/power/reset/regulator-poweroff.c:	WARN_ON(1);

Ohh, duh, ok. Cute.

Can we do the WARN_ONCE(1, "Unable ...") pattern? Then we don't need a
comment since the warn message makes it obvious.