linux-kernel - Re: [PATCH] mfd: sm501: Remove unused sm501_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB49Co-q19pf3yO0@gallifrey>
Date: Fri, 9 May 2025 17:36:10 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: sm501: Remove unused sm501_find_clock

* Lee Jones (lee@...nel.org) wrote:
> On Thu, 08 May 2025, linux@...blig.org wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > sm501_find_clock() was added in 2007 as part of
> > commit b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
> > but hasn't been used.
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >  drivers/mfd/sm501.c | 43 -------------------------------------------
> 
> Looks like you missed: include/linux/sm501.h.

Oops! Sorry about that, v2 posted; message id 20250509173521.49596-1-linux@...blig.org

Thanks for the review,

Dave

> >  1 file changed, 43 deletions(-)
> > 
> > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> > index 7ee293b09f62..bdeea0047e1b 100644
> > --- a/drivers/mfd/sm501.c
> > +++ b/drivers/mfd/sm501.c
> > @@ -631,49 +631,6 @@ unsigned long sm501_set_clock(struct device *dev,
> >  
> >  EXPORT_SYMBOL_GPL(sm501_set_clock);
> >  
> > -/* sm501_find_clock
> > - *
> > - * finds the closest available frequency for a given clock
> > -*/
> > -
> > -unsigned long sm501_find_clock(struct device *dev,
> > -			       int clksrc,
> > -			       unsigned long req_freq)
> > -{
> > -	struct sm501_devdata *sm = dev_get_drvdata(dev);
> > -	unsigned long sm501_freq; /* the frequency achieveable by the 501 */
> > -	struct sm501_clock to;
> > -
> > -	switch (clksrc) {
> > -	case SM501_CLOCK_P2XCLK:
> > -		if (sm->rev >= 0xC0) {
> > -			/* SM502 -> use the programmable PLL */
> > -			sm501_freq = (sm501_calc_pll(2 * req_freq,
> > -						     &to, 5) / 2);
> > -		} else {
> > -			sm501_freq = (sm501_select_clock(2 * req_freq,
> > -							 &to, 5) / 2);
> > -		}
> > -		break;
> > -
> > -	case SM501_CLOCK_V2XCLK:
> > -		sm501_freq = (sm501_select_clock(2 * req_freq, &to, 3) / 2);
> > -		break;
> > -
> > -	case SM501_CLOCK_MCLK:
> > -	case SM501_CLOCK_M1XCLK:
> > -		sm501_freq = sm501_select_clock(req_freq, &to, 3);
> > -		break;
> > -
> > -	default:
> > -		sm501_freq = 0;		/* error */
> > -	}
> > -
> > -	return sm501_freq;
> > -}
> > -
> > -EXPORT_SYMBOL_GPL(sm501_find_clock);
> > -
> >  static struct sm501_device *to_sm_device(struct platform_device *pdev)
> >  {
> >  	return container_of(pdev, struct sm501_device, pdev);
> > -- 
> > 2.49.0
> > 
> 
> -- 
> Lee Jones [李琼斯]
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/