linux-kernel - Re: [PATCH v2] nvme-pci: lock per namespace in nvme_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250509033318.GA27794@lst.de>
Date: Fri, 9 May 2025 05:33:18 +0200
From: Christoph Hellwig <hch@....de>
To: Keith Busch <kbusch@...nel.org>
Cc: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
	Hannes Reinecke <hare@...nel.org>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvme-pci: lock per namespace in nvme_poll_irqdisable

On Thu, May 08, 2025 at 12:14:32PM -0600, Keith Busch wrote:
> On Thu, May 08, 2025 at 04:57:06PM +0200, Daniel Wagner wrote:
> > From: Keith Busch <kbusch@...nel.org>
> > 
> > We need to lock this queue for that condition because the timeout work
> > executes per-namespace.
> > 
> > Reported-by: Hannes Reinecke <hare@...nel.org>
> > Closes: https://lore.kernel.org/all/20240902130728.1999-1-hare@kernel.org/
> > Fixes: a0fa9647a54e ("NVMe: add blk polling support")
> > Signed-off-by: Keith Busch <kbusch@...nel.org>
> > Signed-off-by: Daniel Wagner <wagi@...nel.org>
> 
> Looks good to me
> 
> Reviewed-by: Keith Busch <kbusch@...nel.org>

This is originally attributed to you, so this review is a bit odd..