linux-kernel - Re: [PATCH v6a 6/8] x86/fpu: Remove xfd argument from __fpstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB5JiE6LupZhmqJ7@google.com>
Date: Fri, 9 May 2025 11:29:28 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Chao Gao <chao.gao@...el.com>
Cc: bp@...en8.de, chang.seok.bae@...el.com, dave.hansen@...el.com, 
	dave.hansen@...ux.intel.com, ebiggers@...gle.com, hpa@...or.com, 
	john.allen@....com, kees@...nel.org, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, mingo@...hat.com, oleg@...hat.com, 
	pbonzini@...hat.com, peterz@...radead.org, rick.p.edgecombe@...el.com, 
	stanspas@...zon.de, tglx@...utronix.de, weijiang.yang@...el.com, 
	x86@...nel.org, xin3.li@...el.com
Subject: Re: [PATCH v6a 6/8] x86/fpu: Remove xfd argument from __fpstate_reset()

On Fri, May 09, 2025, Chao Gao wrote:
> The initial values for fpstate::xfd differ between guest and host fpstates.
> Currently, the initial values are passed as an argument to
> __fpstate_reset(). But, __fpstate_reset() already assigns different default
> features and sizes based on the type of fpstates (i.e., guest or host). So,
> handle fpstate::xfd in a similar way to highlight the differences in the
> initial xfd value between guest and host fpstates
> 
> Suggested-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Chao Gao <chao.gao@...el.com>
> Link: https://lore.kernel.org/all/aBuf7wiiDT0Wflhk@google.com/
> ---
> v6a: new.
> 
> Note: this quick revision is just intended to ensure that the feedback
> has been properly addressed.

Both patches LGTM.