| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202505100217.0jMyMEHN-lkp@intel.com>
Date: Sat, 10 May 2025 02:37:41 +0800
From: kernel test robot <lkp@...el.com>
To: Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
Köry Maincent <kory.maincent@...tlin.com>,
Wei Fang <wei.fang@....com>, Clark Wang <xiaoning.wang@....com>,
Andrew Lunn <andrew@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Claudiu Manoil <claudiu.manoil@....com>,
Simon Horman <horms@...nel.org>,
Richard Cochran <richardcochran@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: enetc: convert to ndo_hwtstamp_get() and
ndo_hwtstamp_set()
Hi Vladimir,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Vladimir-Oltean/net-enetc-convert-to-ndo_hwtstamp_get-and-ndo_hwtstamp_set/20250508-194458
base: net-next/main
patch link: https://lore.kernel.org/r/20250508114310.1258162-1-vladimir.oltean%40nxp.com
patch subject: [PATCH net-next] net: enetc: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
config: arm64-randconfig-002-20250509 (https://download.01.org/0day-ci/archive/20250510/202505100217.0jMyMEHN-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250510/202505100217.0jMyMEHN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505100217.0jMyMEHN-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from arch/arm64/include/asm/rwonce.h:71,
from include/linux/compiler.h:390,
from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/timer.h:5,
from drivers/net/ethernet/freescale/enetc/enetc.h:4,
from drivers/net/ethernet/freescale/enetc/enetc.c:4:
>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
#define NULL ((void *)0)
^~~~
drivers/net/ethernet/freescale/enetc/enetc.h:495:50: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_set(ndev, config, extack) NULL
^~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3265:5: note: in expansion of macro 'enetc_hwtstamp_set'
int enetc_hwtstamp_set(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
>> include/linux/stddef.h:8:23: error: expected ')' before numeric constant
#define NULL ((void *)0)
^
drivers/net/ethernet/freescale/enetc/enetc.h:495:50: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_set(ndev, config, extack) NULL
^~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3265:5: note: in expansion of macro 'enetc_hwtstamp_set'
int enetc_hwtstamp_set(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/printk.h:8,
from include/asm-generic/bug.h:22,
from arch/arm64/include/asm/bug.h:26,
from include/linux/ktime.h:24,
from include/linux/timer.h:6,
from drivers/net/ethernet/freescale/enetc/enetc.h:4,
from drivers/net/ethernet/freescale/enetc/enetc.c:4:
>> drivers/net/ethernet/freescale/enetc/enetc.c:3312:19: error: 'enetc_hwtstamp_set' undeclared here (not in a function); did you mean 'enetc_tstamp_tx'?
EXPORT_SYMBOL_GPL(enetc_hwtstamp_set);
^~~~~~~~~~~~~~~~~~
include/linux/export.h:70:16: note: in definition of macro '__EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
include/linux/export.h:84:33: note: in expansion of macro '_EXPORT_SYMBOL'
#define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
^~~~~~~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3312:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(enetc_hwtstamp_set);
^~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from arch/arm64/include/asm/rwonce.h:71,
from include/linux/compiler.h:390,
from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/timer.h:5,
from drivers/net/ethernet/freescale/enetc/enetc.h:4,
from drivers/net/ethernet/freescale/enetc/enetc.c:4:
>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
#define NULL ((void *)0)
^~~~
drivers/net/ethernet/freescale/enetc/enetc.h:494:43: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_get(ndev, config) NULL
^~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3314:5: note: in expansion of macro 'enetc_hwtstamp_get'
int enetc_hwtstamp_get(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
>> include/linux/stddef.h:8:23: error: expected ')' before numeric constant
#define NULL ((void *)0)
^
drivers/net/ethernet/freescale/enetc/enetc.h:494:43: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_get(ndev, config) NULL
^~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3314:5: note: in expansion of macro 'enetc_hwtstamp_get'
int enetc_hwtstamp_get(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/printk.h:8,
from include/asm-generic/bug.h:22,
from arch/arm64/include/asm/bug.h:26,
from include/linux/ktime.h:24,
from include/linux/timer.h:6,
from drivers/net/ethernet/freescale/enetc/enetc.h:4,
from drivers/net/ethernet/freescale/enetc/enetc.c:4:
>> drivers/net/ethernet/freescale/enetc/enetc.c:3333:19: error: 'enetc_hwtstamp_get' undeclared here (not in a function); did you mean 'enetc_hwtstamp_set'?
EXPORT_SYMBOL_GPL(enetc_hwtstamp_get);
^~~~~~~~~~~~~~~~~~
include/linux/export.h:70:16: note: in definition of macro '__EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
include/linux/export.h:84:33: note: in expansion of macro '_EXPORT_SYMBOL'
#define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
^~~~~~~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc.c:3333:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(enetc_hwtstamp_get);
^~~~~~~~~~~~~~~~~
--
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from arch/arm64/include/asm/rwonce.h:71,
from include/linux/compiler.h:390,
from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/timer.h:5,
from enetc.h:4,
from enetc.c:4:
>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
#define NULL ((void *)0)
^~~~
enetc.h:495:50: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_set(ndev, config, extack) NULL
^~~~
enetc.c:3265:5: note: in expansion of macro 'enetc_hwtstamp_set'
int enetc_hwtstamp_set(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
>> include/linux/stddef.h:8:23: error: expected ')' before numeric constant
#define NULL ((void *)0)
^
enetc.h:495:50: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_set(ndev, config, extack) NULL
^~~~
enetc.c:3265:5: note: in expansion of macro 'enetc_hwtstamp_set'
int enetc_hwtstamp_set(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/printk.h:8,
from include/asm-generic/bug.h:22,
from arch/arm64/include/asm/bug.h:26,
from include/linux/ktime.h:24,
from include/linux/timer.h:6,
from enetc.h:4,
from enetc.c:4:
enetc.c:3312:19: error: 'enetc_hwtstamp_set' undeclared here (not in a function); did you mean 'enetc_tstamp_tx'?
EXPORT_SYMBOL_GPL(enetc_hwtstamp_set);
^~~~~~~~~~~~~~~~~~
include/linux/export.h:70:16: note: in definition of macro '__EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
include/linux/export.h:84:33: note: in expansion of macro '_EXPORT_SYMBOL'
#define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
^~~~~~~~~~~~~~
enetc.c:3312:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(enetc_hwtstamp_set);
^~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from arch/arm64/include/asm/rwonce.h:71,
from include/linux/compiler.h:390,
from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/timer.h:5,
from enetc.h:4,
from enetc.c:4:
>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
#define NULL ((void *)0)
^~~~
enetc.h:494:43: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_get(ndev, config) NULL
^~~~
enetc.c:3314:5: note: in expansion of macro 'enetc_hwtstamp_get'
int enetc_hwtstamp_get(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
>> include/linux/stddef.h:8:23: error: expected ')' before numeric constant
#define NULL ((void *)0)
^
enetc.h:494:43: note: in expansion of macro 'NULL'
#define enetc_hwtstamp_get(ndev, config) NULL
^~~~
enetc.c:3314:5: note: in expansion of macro 'enetc_hwtstamp_get'
int enetc_hwtstamp_get(struct net_device *ndev,
^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/printk.h:8,
from include/asm-generic/bug.h:22,
from arch/arm64/include/asm/bug.h:26,
from include/linux/ktime.h:24,
from include/linux/timer.h:6,
from enetc.h:4,
from enetc.c:4:
enetc.c:3333:19: error: 'enetc_hwtstamp_get' undeclared here (not in a function); did you mean 'enetc_hwtstamp_set'?
EXPORT_SYMBOL_GPL(enetc_hwtstamp_get);
^~~~~~~~~~~~~~~~~~
include/linux/export.h:70:16: note: in definition of macro '__EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
include/linux/export.h:84:33: note: in expansion of macro '_EXPORT_SYMBOL'
#define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "GPL")
^~~~~~~~~~~~~~
enetc.c:3333:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(enetc_hwtstamp_get);
^~~~~~~~~~~~~~~~~
vim +3312 drivers/net/ethernet/freescale/enetc/enetc.c
3264
3265 int enetc_hwtstamp_set(struct net_device *ndev,
3266 struct kernel_hwtstamp_config *config,
3267 struct netlink_ext_ack *extack)
3268 {
3269 struct enetc_ndev_priv *priv = netdev_priv(ndev);
3270 int err, new_offloads = priv->active_offloads;
3271
3272 switch (config->tx_type) {
3273 case HWTSTAMP_TX_OFF:
3274 new_offloads &= ~ENETC_F_TX_TSTAMP_MASK;
3275 break;
3276 case HWTSTAMP_TX_ON:
3277 new_offloads &= ~ENETC_F_TX_TSTAMP_MASK;
3278 new_offloads |= ENETC_F_TX_TSTAMP;
3279 break;
3280 case HWTSTAMP_TX_ONESTEP_SYNC:
3281 if (!enetc_si_is_pf(priv->si))
3282 return -EOPNOTSUPP;
3283
3284 new_offloads &= ~ENETC_F_TX_TSTAMP_MASK;
3285 new_offloads |= ENETC_F_TX_ONESTEP_SYNC_TSTAMP;
3286 break;
3287 default:
3288 return -ERANGE;
3289 }
3290
3291 switch (config->rx_filter) {
3292 case HWTSTAMP_FILTER_NONE:
3293 new_offloads &= ~ENETC_F_RX_TSTAMP;
3294 break;
3295 default:
3296 new_offloads |= ENETC_F_RX_TSTAMP;
3297 config->rx_filter = HWTSTAMP_FILTER_ALL;
3298 }
3299
3300 if ((new_offloads ^ priv->active_offloads) & ENETC_F_RX_TSTAMP) {
3301 bool extended = !!(new_offloads & ENETC_F_RX_TSTAMP);
3302
3303 err = enetc_reconfigure(priv, extended, NULL, NULL);
3304 if (err)
3305 return err;
3306 }
3307
3308 priv->active_offloads = new_offloads;
3309
3310 return 0;
3311 }
> 3312 EXPORT_SYMBOL_GPL(enetc_hwtstamp_set);
3313
3314 int enetc_hwtstamp_get(struct net_device *ndev,
3315 struct kernel_hwtstamp_config *config)
3316 {
3317 struct enetc_ndev_priv *priv = netdev_priv(ndev);
3318
3319 config->flags = 0;
3320
3321 if (priv->active_offloads & ENETC_F_TX_ONESTEP_SYNC_TSTAMP)
3322 config->tx_type = HWTSTAMP_TX_ONESTEP_SYNC;
3323 else if (priv->active_offloads & ENETC_F_TX_TSTAMP)
3324 config->tx_type = HWTSTAMP_TX_ON;
3325 else
3326 config->tx_type = HWTSTAMP_TX_OFF;
3327
3328 config->rx_filter = (priv->active_offloads & ENETC_F_RX_TSTAMP) ?
3329 HWTSTAMP_FILTER_ALL : HWTSTAMP_FILTER_NONE;
3330
3331 return 0;
3332 }
> 3333 EXPORT_SYMBOL_GPL(enetc_hwtstamp_get);
3334
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists